dongjoon-hyun commented on issue #23389: [2.4] revert [SPARK-26021][SQL] replace minus zero with zero in Platform.putDouble/Float URL: https://github.com/apache/spark/pull/23389#issuecomment-578914964 Thanks, @srowen . In the email thread, I don't make a judge on any of the cases. I collected and share our behavior to make a more clear communication way to encourage this kind of discussions. :) > given your email thread, I'm still not clear on the logic for reverting this one. For the following question, https://github.com/apache/spark/pull/23043#issuecomment-450004873 was @cloud-fan 's decision comment on the original PR. That was the only one I found. > I also just don't see any comments anywhere about the reasoning I feel in the same way with you, but I also remember that we made a different decision in this type of issues. For me, this has been a political decision instead of a technical decision. And, if there was a reverting request on the old branch, we tend to accept it because we are conservative and afraid of any unknown regression and pipeline failures. > Behavior changes are needed to fix correctness problems in behavior, no?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
