srowen commented on issue #23389: [2.4] revert [SPARK-26021][SQL] replace minus zero with zero in Platform.putDouble/Float URL: https://github.com/apache/spark/pull/23389#issuecomment-578916767 Right, worth discussing. Everything is a judgment call, but I'd like to understand the 'judgment'. The logic can't be: "we can't fix correctness issues because it means changing incorrect behavior to correct behavior". I assume the logic was: the behavior change causes more problems than fixing the correctness, which could be fine. My particular issue here is that this PR changed a few things, and I infer that one thing was an issue (NaN handling?) when the important correctness issue was elsewhere (0.0 vs -0.0). Wholesale reverting might be the wrong call.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
