mridulm commented on a change in pull request #26682: [SPARK-29306][CORE] Stage
Level Sched: Executors need to track what ResourceProfile they are created with
URL: https://github.com/apache/spark/pull/26682#discussion_r371503061
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -392,8 +418,26 @@ private[spark] class ExecutorMonitor(
* which the `SparkListenerTaskStart` event is posted before the
`SparkListenerBlockManagerAdded`
* event, which is possible because these events are posted in different
threads. (see SPARK-4951)
*/
- private def ensureExecutorIsTracked(id: String): Tracker = {
- executors.computeIfAbsent(id, _ => new Tracker())
+ private def ensureExecutorIsTracked(id: String, resourceProfileId: Int):
Tracker = {
+ val numExecsWithRpId =
execResourceProfileCount.computeIfAbsent(resourceProfileId, _ => 0)
+ val execTracker = executors.computeIfAbsent(id, _ => {
+ val newcount = numExecsWithRpId + 1
+ execResourceProfileCount.put(resourceProfileId, newcount)
+ logDebug(s"Executor added with ResourceProfile id: $resourceProfileId
" +
+ s"count is now $newcount")
+ new Tracker(resourceProfileId)
+ })
Review comment:
If all updates are expected to be single threaded, then change to compute
makes no sense (it will simply complicate the code) - I probably missed some
note indicating this is the expectation !
Thanks for elaborating Tom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
