maropu commented on a change in pull request #27372:
[SPARK-30234][SQL][FOLLOWUP] Add `.enabled` in the suffix of the ADD FILE
legacy option
URL: https://github.com/apache/spark/pull/27372#discussion_r371651772
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2116,11 +2116,13 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
- val LEGACY_ADD_DIRECTORY_USING_RECURSIVE =
buildConf("spark.sql.legacy.addDirectory.recursive")
- .doc("When true, users can add directory by passing path of a directory to
ADD FILE " +
- "command of SQL. If false, then only a single file can be added.")
- .booleanConf
- .createWithDefault(true)
+ val LEGACY_ADD_DIRECTORY_USING_RECURSIVE =
+ buildConf("spark.sql.legacy.addDirectory.recursive.enabled")
+ .internal()
Review comment:
We need `internal()` for legacy options? Currently, some of the legacy
options have `internal()` and the others have not. Any consistent policy for
that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
