Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4699#discussion_r25040245
  
    --- Diff: graphx/pom.xml ---
    @@ -45,9 +45,14 @@
           <artifactId>guava</artifactId>
         </dependency>
         <dependency>
    -      <groupId>org.jblas</groupId>
    -      <artifactId>jblas</artifactId>
    -      <version>${jblas.version}</version>
    +      <groupId>com.github.fommil.netlib</groupId>
    +      <artifactId>core</artifactId>
    +      <version>1.1.2</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>net.sourceforge.f2j</groupId>
    +      <artifactId>arpack_combined_all</artifactId>
    +      <version>0.1</version>
    --- End diff --
    
    Should this be runtime-only scope? is this basically a pure Java backend to 
netlib? I checked the .jar and it seems to be all Java. I double-checked and 
this is BSD licensed. Since license issues are front of mind in this change, 
add a line for this new lib in the `LICENSE` file under the other BSD 
dependencies?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to