zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-579284495 @dongjoon-hyun > ? @zero323 . It seems that you missed my point. I advised like the following. > > > I'd like to recommend you to mention what you've done clearly. That's enough. > > Let me rephrase my words. "In the PR description, write that you didn't run the full test. Especially Arrow tests are skipped". It was my request. Seems like. I guess there is something lost in translation here > We cannot say We're good when we know something wrong Especially what we consider "wrong" in this context, hence my elaborate response. Which I think is still valid ‒ overall test matrix is tiny compared to what is officially supported. Sadly Arrow makes things worse as - It is not Maven dependency. - Building from source is pain, and repositories don't provide archival versions. - Depending on OS, there are also additional dependencies. - Breaking API changes are not unusual (for example it changed between first 3.0.0 preview and the second), leading to rather [cryptic errors](https://twitter.com/_zero323/status/1202005430471450625). It would be great if we could either isolate that (I played a bit with Anaconda for that, and results are quite promising, but I am not there yet, not to mention it won't help with all the tech. debt caused by supporting long outdated R and Python versions), or find a way to bundle within Maven builds. For now I published [zero323/sparkr-build-sandbox](https://github.com/zero323/sparkr-build-sandbox) ([docker.com/r/zero323/sparkr-build-sandbox](https://hub.docker.com/r/zero323/sparkr-build-sandbox)) - not exactly what is needed, but does the trick for now. Please check updated description and let me know if that addresses your concerns.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
