srowen commented on a change in pull request #27374: [SPARK-30659][ML][PYSPARK]
LogisticRegression blockify input vectors
URL: https://github.com/apache/spark/pull/27374#discussion_r371900891
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/optim/aggregator/LogisticAggregatorSuite.scala
##########
@@ -32,21 +32,21 @@ class LogisticAggregatorSuite extends SparkFunSuite with
MLlibTestSparkContext {
override def beforeAll(): Unit = {
super.beforeAll()
- instances = Array(
+ instances = standardize(Array(
Review comment:
This may be a dumb question, but you're not saying that LR input itself has
to be standardized first, right? this is just required to meet preconditions of
this aggregator? just trying to get a handle on why it wasn't required before.
LR now standardizes internally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
