clarkead commented on issue #27370: [SPARK-30654] Bootstrap4 WebUI upgrade URL: https://github.com/apache/spark/pull/27370#issuecomment-579539345 Thank you for taking a look. The intention with this patch is not to change any functionality. The goal is to just migrate Spark's WebUI onto a supported Bootstrap release. Due to Bootstrap changing some of their default CSS the font sizes, paddings, and margins did change. As a result, I made some overrides in the CSS and some minor changes to the HTML markup to try and maintain the existing feel, but there are still minor differences. It should be noted that the main navbar does collapse to a toggle button now for mobile devices. Previously when viewed on a mobile device or small browser window the top navbar would become partially cut off. jQuery was not modified as it was already on version 3.4.1, but dataTables.bootstrap.min.js was updated to the latest dataTables.bootstrap4.min.js and jquery.dataTables.1.10.18.min.js was updated to jquery.dataTables.min.js (version 1.10.20). This was mostly needed for compatibility with the latest Bootstrap 4 release. I noticed this afternoon my initial PR had an issue with my upstream merge so I've added a new commit to resolve it. I'll look into the reported license issue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
