HyukjinKwon commented on a change in pull request #27376:
[SPARK-30665][PYSPARK] Remove Pandoc dependency in PySpark setup.py
URL: https://github.com/apache/spark/pull/27376#discussion_r372154009
##########
File path: python/setup.py
##########
@@ -153,21 +153,15 @@ def _supports_symlinks():
# will search for SPARK_HOME with Python.
scripts.append("pyspark/find_spark_home.py")
- # Parse the README markdown file into rst for PyPI
- long_description = "!!!!! missing pandoc do not upload to PyPI !!!!"
- try:
- import pypandoc
- long_description = pypandoc.convert('README.md', 'rst')
- except ImportError:
- print("Could not import pypandoc - required to package PySpark",
file=sys.stderr)
- except OSError:
- print("Could not convert - pandoc is not installed", file=sys.stderr)
+ with open('README.md') as f:
Review comment:
Yea, I think PyPi renders md files fine without rst.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
