Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4363#discussion_r25042970
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1035,6 +1035,8 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
         postEnvironmentUpdate()
       }
     
    +  private[spark] def supportKillExecutor = master.contains("yarn") || 
dynamicAllocationTesting
    --- End diff --
    
    this is also used in `requestExecutors` so we need to generalize the name. 
Also, please add a java doc
    ```
    /**
     * Return whether dynamically adjusting the amount of resources allocated to
     * this application is supported. This is currently only available for YARN.
     */
    private[spark] def supportDynamicAllocation = master.contains("yarn") || 
dynamicAllocationTesting
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to