nchammas commented on a change in pull request #27376: [SPARK-30665][PYSPARK] 
Eliminate pypandoc dependency
URL: https://github.com/apache/spark/pull/27376#discussion_r372746565
 
 

 ##########
 File path: dev/requirements.txt
 ##########
 @@ -2,5 +2,4 @@ flake8==3.5.0
 jira==1.0.3
 PyGithub==1.26.0
 Unidecode==0.04.19
-pypandoc==1.3.3
 
 Review comment:
   I don't think it's needed for R. R needs pandoc. pypandoc is a Python 
wrapper around pandoc, and in most cases you need to separately install pandoc 
at the system level before you can install pypandoc.
   
   The pypandoc README claims that [macOS wheels for pypandoc include 
pandoc](https://github.com/bebraw/pypandoc#installing-via-pip), but in my 
experience I have to install pandoc separately with `brew`. pypandoc doesn't 
even claim to bundle pandoc on Linux. So I doubt this line is really needed.
   
   I'm trying to confirm this myself, but the [two `Rscript` lines in the docs 
README](https://github.com/apache/spark/blob/b1f81f0072b06865ea1fdfe4c510474e64d39cfe/docs/README.md#prerequisites)
 take so long to run! I'll post an update when I've completed my test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to