cloud-fan commented on a change in pull request #27350: [SPARK-30615][SQL]
Introduce Analyzer rule for V2 AlterTable column change resolution
URL: https://github.com/apache/spark/pull/27350#discussion_r372921912
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -3002,6 +3004,161 @@ class Analyzer(
}
}
}
+
+ /** Rule to mostly resolve, normalize and rewrite column names based on case
sensitivity. */
+ object ResolveAlterTableChanges extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp {
+ case a @ AlterTable(_, _, t: NamedRelation, changes) if t.resolved =>
+ val schema = t.schema
+ val normalizedChanges = changes.flatMap {
+ case add: AddColumn =>
+ val parent = add.fieldNames().init
+ if (parent.nonEmpty) {
+ // Adding a nested field, need to normalize the parent column
and position
+ val target = schema.findNestedField(parent, includeCollections =
true, conf.resolver)
+ if (target.isEmpty) {
+ // Leave unresolved. Throws error in CheckAnalysis
+ Some(add)
+ } else {
+ val (normalizedName, sf) = target.get
+ sf.dataType match {
+ case struct: StructType =>
+ val pos = findColumnPosition(add.position(),
parent.quoted, struct)
+ Some(TableChange.addColumn(
+ (normalizedName ++ Seq(sf.name,
add.fieldNames().last)).toArray,
+ add.dataType(),
+ add.isNullable,
+ add.comment,
+ pos))
+
+ case other =>
+ throw new AnalysisException(
Review comment:
shall we return None here as well? `CheckAnalysis` also throws error for
this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
