zsxwing commented on a change in pull request #27373:
[SPARK-30657][SPARK-30658][SS] Fixed two bugs in streaming limits
URL: https://github.com/apache/spark/pull/27373#discussion_r373098837
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala
##########
@@ -976,24 +976,48 @@ class StreamSuite extends StreamTest {
CheckAnswer(1 to 3: _*))
}
- test("streaming limit in complete mode") {
+ test("streaming limit before agg in complete mode") {
Review comment:
nit: could you add the jira id to the test name? We recently added the
following rule:
`Also, you should consider writing a JIRA ID in the tests when your pull
request targets to fix a specific issue. In practice, usually it is added when
a JIRA type is a bug or a PR adds a couple of tests to an existing test class.
See the examples below:
Scala
test("SPARK-12345: a short description of the test") {
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
