dongjoon-hyun commented on a change in pull request #27405:
[SPARK-30684][WEBUI] ] Show the descripton of metrics for WholeStageCodegen in
DAG viz
URL: https://github.com/apache/spark/pull/27405#discussion_r373102890
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
##########
@@ -198,7 +203,7 @@ private[ui] class SparkPlanGraphCluster(
require(duration.length == 1)
val id = duration(0).accumulatorId
if (metricsValue.contains(duration(0).accumulatorId)) {
Review comment:
While you are here, can we change like this?
```scala
- if (metricsValue.contains(duration(0).accumulatorId)) {
+ if (metricsValue.contains(id)) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
