brkyvz commented on a change in pull request #27388: [SPARK-30656][SS] Support
the "minPartitions" option in Kafka batch source and streaming source v1
URL: https://github.com/apache/spark/pull/27388#discussion_r372699645
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
##########
@@ -106,6 +101,8 @@ private[kafka010] case class KafkaOffsetRange(
topicPartition: TopicPartition,
fromOffset: Long,
untilOffset: Long,
- preferredLoc: Option[String]) {
- lazy val size: Long = untilOffset - fromOffset
+ preferredLoc: Option[String] = None) {
+ def topic: String = topicPartition.topic
+ def partition: Int = topicPartition.partition
+ def size: Long = untilOffset - fromOffset
Review comment:
I realize this was already there but this isn't correct for compacted
topics, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
