marmbrus commented on issue #23811: [SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType URL: https://github.com/apache/spark/pull/23811#issuecomment-580443958 As a somewhat heavy user of Datasets I'm actually +1 on letting users get nicer implementations of Timestamp out of Spark. The flag is not the most elegant way to expose this, but in some cases I think its our only choice (i.e. when Spark is returning `GenericRow`s without any other hint from the users about the type they want) Apologies, if I misread the PR, but couldn't we seamlessly support both types in many cases without the flag? (i.e. when reflection can tell us which type the user is expecting). That said, I'm -1 on making this the default anytime soon. Sounds like it will break a lot of programs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
