brkyvz commented on a change in pull request #27391: [SPARK-30612][SQL] Resolve
qualified column name with v2 tables
URL: https://github.com/apache/spark/pull/27391#discussion_r373187164
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala
##########
@@ -49,19 +49,21 @@ sealed trait IdentifierWithDatabase {
/**
* Encapsulates an identifier that is either a alias name or an identifier
that has table
- * name and optionally a database name.
+ * name and a namespace.
* The SubqueryAlias node keeps track of the qualifier using the information
in this structure
- * @param identifier - Is an alias name or a table name
- * @param database - Is a database name and is optional
+ * @param name - Is an alias name or a table name
+ * @param namespace - Is a namespace
*/
-case class AliasIdentifier(identifier: String, database: Option[String])
- extends IdentifierWithDatabase {
+case class AliasIdentifier(name: String, namespace: Seq[String]) {
Review comment:
nit: It may also contain the catalog information so `namespace` isn't really
correct. How about qualifiers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
