brkyvz commented on issue #27391: [SPARK-30612][SQL] Resolve qualified column name with v2 tables URL: https://github.com/apache/spark/pull/27391#issuecomment-580521979 I don't think so for ALTER TABLE. You don't have any ambiguity there with respect to columns, therefore wouldn't need to add qualifiers to the columns. I don't think v1 commands work with qualifiers either but we should check. On Thu, Jan 30, 2020, 2:15 PM Terry Kim <[email protected]> wrote: > *@imback82* commented on this pull request. > ------------------------------ > > In > sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala > <https://github.com/apache/spark/pull/27391#discussion_r373222911>: > > > @@ -389,7 +389,7 @@ case class DropTable( > case class AlterTable( > catalog: TableCatalog, > ident: Identifier, > - table: NamedRelation, > + table: LogicalPlan, > > Don't we need to wrap this with SubqueryAlias (which is not a > NamedRelation)? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/27391?email_source=notifications&email_token=ABIAE6Z7TODNEZUJ2PH5QHDRANGO3A5CNFSM4KNPCTF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTXJLFI#discussion_r373222911>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABIAE6YXO43QX23P5SHNKNTRANGO3ANCNFSM4KNPCTFQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
