Github user hotou commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4701#discussion_r25071164
  
    --- Diff: core/src/test/scala/org/apache/spark/rdd/JdbcRDDSuite.scala ---
    @@ -29,22 +29,42 @@ class JdbcRDDSuite extends FunSuite with BeforeAndAfter 
with LocalSparkContext {
         Class.forName("org.apache.derby.jdbc.EmbeddedDriver")
         val conn = 
DriverManager.getConnection("jdbc:derby:target/JdbcRDDSuiteDb;create=true")
         try {
    -      val create = conn.createStatement
    -      create.execute("""
    -        CREATE TABLE FOO(
    -          ID INTEGER NOT NULL GENERATED ALWAYS AS IDENTITY (START WITH 1, 
INCREMENT BY 1),
    -          DATA INTEGER
    -        )""")
    -      create.close()
    -      val insert = conn.prepareStatement("INSERT INTO FOO(DATA) VALUES(?)")
    -      (1 to 100).foreach { i =>
    -        insert.setInt(1, i * 2)
    -        insert.executeUpdate
    +
    --- End diff --
    
    I just want to add a new test for this bug, is this not the right place to 
put it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to