tgravescs commented on a change in pull request #27367: [SPARK-30638][CORE] Add 
resources allocated to PluginContext
URL: https://github.com/apache/spark/pull/27367#discussion_r373295765
 
 

 ##########
 File path: 
core/src/main/scala/org/apache/spark/internal/plugin/PluginContainer.scala
 ##########
 @@ -133,17 +140,27 @@ object PluginContainer {
 
   val EXTRA_CONF_PREFIX = "spark.plugins.internal.conf."
 
-  def apply(sc: SparkContext): Option[PluginContainer] = 
PluginContainer(Left(sc))
+  def apply(
+      sc: SparkContext,
+      resources: java.util.Map[String, ResourceInformation]
+  ): Option[PluginContainer] = PluginContainer(Left(sc), resources)
 
 Review comment:
   hmm, indentation is correct by IntelliJ scalastyle, I've seen it both ways, 
I'll change it though as I think this is less used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to