HyukjinKwon commented on a change in pull request #27085: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/27085#discussion_r373307820
########## File path: core/src/main/resources/META-INF/services/org.apache.spark.deploy.history.EventFilterBuilder ########## @@ -0,0 +1 @@ +org.apache.spark.deploy.history.BasicEventFilterBuilder Review comment: I see. I think that's possible via simply using reflection which I think is easier to read the codes. I think we're already doing this in few places such as `FileCommitProtocol.instantiate` Seems a bit odds to use service loader for internal classes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
