dongjoon-hyun commented on a change in pull request #27366: [SPARK-30648][SQL]
Support filters pushdown in JSON datasource
URL: https://github.com/apache/spark/pull/27366#discussion_r373354711
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
##########
@@ -40,7 +40,8 @@ import org.apache.spark.util.Utils
class JacksonParser(
schema: DataType,
val options: JSONOptions,
- allowArrayAsStructs: Boolean) extends Logging {
+ allowArrayAsStructs: Boolean,
+ filters: Seq[Filter]) extends Logging {
Review comment:
Shall we have a default value `Seq.empty` for this `filters`? Then, we can
remove the redundant constructor changes in this PR. I saw multiple instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
