MaxGekk commented on a change in pull request #27366: [SPARK-30648][SQL] 
Support filters pushdown in JSON datasource
URL: https://github.com/apache/spark/pull/27366#discussion_r373386384
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
 ##########
 @@ -40,7 +40,8 @@ import org.apache.spark.util.Utils
 class JacksonParser(
     schema: DataType,
     val options: JSONOptions,
-    allowArrayAsStructs: Boolean) extends Logging {
+    allowArrayAsStructs: Boolean,
+    filters: Seq[Filter]) extends Logging {
 
 Review comment:
   I didn't do that because wanted the compiler to show me all places where 
JacksonParser is instantiated to be sure I pass correct filters

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to