fuwhu commented on a change in pull request #27129: [SPARK-30427][SQL] Add 
config item for limiting partition number when calculating statistics through 
File System
URL: https://github.com/apache/spark/pull/27129#discussion_r373416305
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
 ##########
 @@ -59,6 +60,21 @@ private[sql] object PruneFileSourcePartitions extends 
Rule[LogicalPlan] {
     Project(projects, withFilter)
   }
 
+  private def getNewStatistics(
+              fileIndex: InMemoryFileIndex,
 
 Review comment:
   > the statistic calculation is just getting the sum of the files
   
   this is true in PruneFileSourcePartitions, because InMemoryFileIndex already 
did file listing. 
   I already partition number check in PruneFileSourcePartitions.
   but this is not true in PruneHiveTablePartitions, the size of each hive 
table partition need to be calculated via HDFS if it's not available in meta 
data.
   
   Please correct me if i am wrong, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to