Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4622#issuecomment-75297368
@viirya I made a pass on the code. Some high-level feedback:
1. What is the expected size of the model? Should we store it
distributively?
2. Defining a private case class to replace `Seq(Double, Double, Double)`
would make the code much easier to read.
3. Please try to add a Java example, which helps test Java API
compatibility.
I will go through the algorithm part again after 2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
