planga82 commented on a change in pull request #26082: [SPARK-29431][WebUI] 
Improve Web UI / Sql tab visualization with cached dataframes.
URL: https://github.com/apache/spark/pull/26082#discussion_r374687557
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanInfo.scala
 ##########
 @@ -33,7 +34,8 @@ class SparkPlanInfo(
     val simpleString: String,
     val children: Seq[SparkPlanInfo],
     val metadata: Map[String, String],
-    val metrics: Seq[SQLMetricInfo]) {
+    val metrics: Seq[SQLMetricInfo],
+    val relation: Seq[SparkPlanInfo] = Seq()) {
 
 Review comment:
   I tried to replicate the same structure that in InMemoryTableScan where the 
relation is a different element and is not a children.
   This attribute has a default value so it not impact in any case where is not 
used. Only in this case is used. Do you think there is a better way to solve it 
without the new attribute? Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to