HyukjinKwon commented on a change in pull request #27459: [SPARK-30510][SQL][Docs] Publicly document Spark SQL configuration options URL: https://github.com/apache/spark/pull/27459#discussion_r375002946
########## File path: sql/gen-sql-markdown.py ########## @@ -15,12 +15,18 @@ # limitations under the License. # -import sys import os +import re +import sys from collections import namedtuple +from textwrap import dedent + +from markdown import markdown Review comment: @nchammas, I know it's a bit hacky but what do you think about we don't add more dependencies here by using `markdown` under `mkdocs` directly? e.g. `from mkdocs.structure.pages.markdown import markdown`. I checked this package from version 1.0.0 ~ master branch. Seems pretty stable. I was thinking it's better to explicitly avoid adding more dependencies. I know `mkdocs` is dependent on `markdown` but different versions are required (see https://github.com/mkdocs/mkdocs/blob/399f8428b84c4a91a00e0388d7e9bb5260dc8ec3/setup.py#L61 as an example). In this way, we can also avoid updating `dev/create-release/spark-rm/Dockerfile` as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
