Github user florianverhein commented on the pull request:
https://github.com/apache/spark/pull/4583#issuecomment-75417014
Sure, so let's support both - I'll remove the addition of the "/", then the
user can choose the behaviour. If you're happy with the current option name
in that case then we're all set. I might add a bit more info to the help
too, so it's clear to users what will happen with/out the /.
Does that sound good @shivaram?
On Sunday, 22 February 2015, Shivaram Venkataraman
<[email protected]>
wrote:
> Sorry I got caught up with some other stuff for the past couple of days.
> @florianverhein <https://github.com/florianverhein> my recommendation is
> hopefully not arbitrary but just that if we take in a directory as an
> argument to --deploy-root-dir then its nicer to keep the directory at the
> destination as well. As you said this is the behavior that rsync supports
> without a trailing / and this is the behavior we support in spark-ec2's
> copy-dir as well.
>
> FWIW I don't think there are any right or wrong choices here and this is
> mostly a question of behavior that will seem most natural to users. It'll
> be great to hear what other EC2 users like @nchammas
> <https://github.com/nchammas> or @JoshRosen <https://github.com/JoshRosen>
> feel about this.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/4583#issuecomment-75397427>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
