cloud-fan commented on a change in pull request #27391: [SPARK-30612][SQL]
Resolve qualified column name with v2 tables
URL: https://github.com/apache/spark/pull/27391#discussion_r375046118
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
##########
@@ -153,13 +152,19 @@ package object expressions {
unique(grouped)
}
- /** Perform attribute resolution given a name and a resolver. */
- def resolve(nameParts: Seq[String], resolver: Resolver):
Option[NamedExpression] = {
+ /** Returns true if all qualifiers in `attrs` have 2 or less parts. */
+ @transient private val hasTwoOrLessPartQualifiers: Boolean =
+ attrs.forall(_.qualifier.length <= 2)
+
+ /** Match attributes for the case where all qualifiers in `attrs` have 2
or less parts. */
+ private def matchWithTwoOrLessPartQualifiers(
Review comment:
nit: `matchWithTwoOrLessQualifierParts`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
