cloud-fan commented on a change in pull request #27444: [SPARK-30614][SQL] The
native ALTER COLUMN syntax should change one property at a time
URL: https://github.com/apache/spark/pull/27444#discussion_r375070537
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -158,12 +158,9 @@ statement
SET TBLPROPERTIES tablePropertyList
#setTableProperties
| ALTER (TABLE | VIEW) multipartIdentifier
UNSET TBLPROPERTIES (IF EXISTS)? tablePropertyList
#unsetTableProperties
- | ALTER TABLE table=multipartIdentifier
+ |ALTER TABLE table=multipartIdentifier
(ALTER | CHANGE) COLUMN? column=multipartIdentifier
- (TYPE dataType)? commentSpec? colPosition?
#alterTableColumn
- | ALTER TABLE table=multipartIdentifier
- ALTER COLUMN? column=multipartIdentifier
- setOrDrop=(SET | DROP) NOT NULL
#alterColumnNullability
Review comment:
I don't have a strong preference as long as they are consistent. Since the
hive style alter column use `CHANGE` and we support that syntax for a long
time, I'm OK to support `CHANGE` as well in the new syntax.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
