dongjoon-hyun commented on a change in pull request #27460: [SPARK-30733][R][HOTFIX] Fix SparkR tests per testthat and R version upgrade URL: https://github.com/apache/spark/pull/27460#discussion_r375083457
########## File path: R/run-tests.sh ########## @@ -31,8 +31,9 @@ NUM_TEST_WARNING="$(grep -c -e 'Warnings ----------------' $LOGFILE)" # Also run the documentation tests for CRAN CRAN_CHECK_LOG_FILE=$FWDIR/cran-check.out rm -f $CRAN_CHECK_LOG_FILE - -NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE +# TODO(SPARK-30737) reenable this once packages are correctly installed in Jenkins +touch $CRAN_CHECK_LOG_FILE +# NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE Review comment: You need remove the following line `FAILED=$((PIPESTATUS[0]||$FAILED))` together. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
