cloud-fan commented on a change in pull request #27449: 
[SPARK-27297][DOC][FOLLOW-UP] Improve documentation for various Scala functions
URL: https://github.com/apache/spark/pull/27449#discussion_r375091273
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##########
 @@ -3488,6 +3511,15 @@ object functions {
    * Applies a binary operator to an initial state and all elements in the 
array,
    * and reduces this to a single state. The final state is converted into the 
final result
    * by applying a finish function.
+   * {{{
+   *   df.select(aggregate(col("i"), lit(0), (acc, x) => acc + x, _ * 10))
+   * }}}
+   *
+   * @param expr the input array column
+   * @param zero the initial value
+   * @param merge (c, v) => c, the merge function to reduce all elements into 
a single state
 
 Review comment:
   `c`, `v` is too vague. How about `(combined_value, input_value) => 
combined_value`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to