Ngone51 commented on a change in pull request #27455: [SPARK-30729][CORE]
Eagerly filter out zombie TaskSetManager before offering resources
URL: https://github.com/apache/spark/pull/27455#discussion_r375126016
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -1082,6 +1083,7 @@ private[spark] class TaskSetManager(
}
def recomputeLocality(): Unit = {
+ if (isZombie) return
Review comment:
We need it because there may be some running tasks on that lost executor for
the zombie TSM and the zombie TSM should handle them properly as failed tasks:
https://github.com/apache/spark/blob/e1ea806b3075d279b5f08a29fe4c1ad6d3c4191a/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala#L938-L948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
