Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4677#discussion_r25138907
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
    @@ -76,8 +77,44 @@ class GradientBoostedTrees(private val boostingStrategy: 
BoostingStrategy)
       def run(input: JavaRDD[LabeledPoint]): GradientBoostedTreesModel = {
         run(input.rdd)
       }
    -}
     
    +  /**
    +   * Method to validate a gradient boosting model
    +   * @param trainInput Training dataset: RDD of 
[[org.apache.spark.mllib.regression.LabeledPoint]].
    +   * @param validateInput Validation dataset:
    +                          RDD of 
[[org.apache.spark.mllib.regression.LabeledPoint]].
    +                          Should follow same distribution as trainInput.
    --- End diff --
    
    I think talking about target distributions may confuse some people.  Maybe 
we can clarify as follows:
    ```
    This dataset should follow the same distribution as trainInput; e.g., these 
two datasets could be created from an original dataset by using 
[[org.apache.spark.rdd.RDD.randomSplit()]].
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to