mridulm commented on a change in pull request #27313: [SPARK-29148][CORE] Add
stage level scheduling dynamic allocation and scheduler backend changes
URL: https://github.com/apache/spark/pull/27313#discussion_r375435280
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -726,14 +894,23 @@ private[spark] class ExecutorAllocationManager(
})
}
- registerGauge("numberExecutorsToAdd", numExecutorsToAdd, 0)
+ // The metrics are going to return the numbers for the default
ResourceProfile.
+ // It would be nice to do include each profile somehow in the future.
Review comment:
Can we make these as aggregate across all resource profiles instead of only
default ? (We can also add a gauge just for default if required).
For existing usecases, this will be exactly same behavior as 2.4 without
resource profile - but for resource aware jobs, it will indicate actual
pending counts and not just default (if no other rp, it is same as default -
so no functional change in that case).
I agree, exposing for all profiles will be very useful when we do it in
future - we will need to namespace it properly for that : that is why I really
want to be able to 'name' resource profiles !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
