Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4677#discussion_r25140126
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -108,12 +145,16 @@ object GradientBoostedTrees extends Logging {
/**
* Internal method for performing regression using trees as base
learners.
* @param input training dataset
+ * @param validateInput validation dataset, ignored if validate is set
to false.
* @param boostingStrategy boosting parameters
+ * @param validate whether or not to use the validation dataset.
* @return a gradient boosted trees model that can be used for prediction
*/
private def boost(
input: RDD[LabeledPoint],
- boostingStrategy: BoostingStrategy): GradientBoostedTreesModel = {
+ validateInput: RDD[LabeledPoint],
+ boostingStrategy: BoostingStrategy,
+ validate: Boolean = false): GradientBoostedTreesModel = {
--- End diff --
no need for default value; better to be explicit internally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
