ecapoccia commented on a change in pull request #27034: [SPARK-30122][K8S]
Support spark.kubernetes.authenticate.executor.serviceAccountName
URL: https://github.com/apache/spark/pull/27034#discussion_r375540770
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStep.scala
##########
@@ -17,19 +17,23 @@
package org.apache.spark.deploy.k8s.features
import org.apache.spark.deploy.k8s.{KubernetesConf, SparkPod}
-import org.apache.spark.deploy.k8s.Config.KUBERNETES_SERVICE_ACCOUNT_NAME
+import
org.apache.spark.deploy.k8s.Config.{KUBERNETES_DRIVER_SERVICE_ACCOUNT_NAME,
KUBERNETES_EXECUTOR_SERVICE_ACCOUNT_NAME}
import org.apache.spark.deploy.k8s.KubernetesUtils.buildPodWithServiceAccount
private[spark] class ExecutorKubernetesCredentialsFeatureStep(kubernetesConf:
KubernetesConf)
extends KubernetesFeatureConfigStep {
- private lazy val driverServiceAccount =
kubernetesConf.get(KUBERNETES_SERVICE_ACCOUNT_NAME)
+
+ private lazy val driverServiceAccount =
kubernetesConf.get(KUBERNETES_DRIVER_SERVICE_ACCOUNT_NAME)
+ private lazy val executorServiceAccount =
+ kubernetesConf.get(KUBERNETES_EXECUTOR_SERVICE_ACCOUNT_NAME)
override def configurePod(pod: SparkPod): SparkPod = {
pod.copy(
- // if not setup by the pod template fallback to the driver's sa,
- // last option is the default sa.
+ // if not setup by the pod template, fallback to the executor's sa,
+ // if executor's sa is not setup, the last option is driver's sa.
pod = if (Option(pod.pod.getSpec.getServiceAccount).isEmpty) {
- buildPodWithServiceAccount(driverServiceAccount,
pod).getOrElse(pod.pod)
Review comment:
hmm. I think you're right by reading the code.
However I am pretty sure that in vanilla Spark if you set the driver service
account name, the executors will be on default.
I think possibly BasicExecutorFeatureStep ignores the config? I think an
integration test will help here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
