MaxGekk opened a new pull request #27474: [WIP] Port `convertTz()` and 
`daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474
 
 
   ### What changes were proposed in this pull request?
   - Rewrite the `convertTz` and `daysToMillis` methods of `DateTimeUtils` 
using Java 8 time API
   - Remove `DateTimeUtils. getOffsetFromLocalMillis`
   - Change types of `convertTz` parameters from `TimeZone` to `ZoneId`. This 
allow to avoid unnecessary conversions `TimeZone` -> `ZoneId`
   
   
   ### Why are the changes needed?
   - Simplifies the code, and make it more maintainable
   - Switches `convertTz` and `daysToMillis` on Proleptic Gregorian calendar 
used by Java 8 time classes by default. That makes the functions consistent to 
other date-time functions. 
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   By existing test suite `DateTimeUtilsSuite`, `DateFunctionsSuite` and 
`DateExpressionsSuite`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to