Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4259#discussion_r25146737
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/sharedParams.scala 
---
    @@ -23,6 +23,27 @@ private[ml] trait HasRegParam extends Params {
       def getRegParam: Double = get(regParam)
     }
     
    +private[ml] trait HasElasticNetParam extends HasRegParam {
    +  /** param for elastic net regularization parameter */
    +  val alphaParam: DoubleParam = new DoubleParam(
    --- End diff --
    
    I'd vote for not using HasRegParam at all and using elastic net-specific 
terminology such as l1RegParam, l2RegParam or something else which makes it 
clear which param applies to which part of the regularization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to