tgravescs commented on a change in pull request #27313: [SPARK-29148][CORE] Add
stage level scheduling dynamic allocation and scheduler backend changes
URL: https://github.com/apache/spark/pull/27313#discussion_r375972799
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -726,14 +894,23 @@ private[spark] class ExecutorAllocationManager(
})
}
- registerGauge("numberExecutorsToAdd", numExecutorsToAdd, 0)
+ // The metrics are going to return the numbers for the default
ResourceProfile.
+ // It would be nice to do include each profile somehow in the future.
Review comment:
oh wait so the reason I didn't was aggregates don't make sense in some of
these cases. Number of executors to add for instance. really I think that is
the only one. The rest we can aggregate.
I could rename that one to be numberExecutorsToAddForDefaultProfile.
thoughts?
note that the number executors to add is simply the number its adding in
that round (that is the exponential ramp up algo for asking for more), its not
the total it needs to add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
