dongjoon-hyun commented on a change in pull request #27477: [SPARK-30724][SQL]
Support 'LIKE ANY' and 'LIKE ALL' operators
URL: https://github.com/apache/spark/pull/27477#discussion_r376136157
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1387,14 +1387,23 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case SqlBaseParser.IN =>
invertIfNotDefined(In(e, ctx.expression.asScala.map(expression)))
case SqlBaseParser.LIKE =>
- val escapeChar = Option(ctx.escapeChar).map(string).map { str =>
- if (str.length != 1) {
- throw new ParseException("Invalid escape string." +
- "Escape string must contains only one character.", ctx)
- }
- str
- }.getOrElse('\\')
- invertIfNotDefined(Like(e, expression(ctx.pattern),
Literal(escapeChar)))
+ Option(ctx.quantifier).map(_.getType) match {
+ case Some(SqlBaseParser.ANY) if !ctx.expression.isEmpty =>
Review comment:
Do we need this `ctx.expression.isEmpty`? It seems that the parser rule
guarantee at least one expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
