HyukjinKwon commented on a change in pull request #27459:
[SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options
URL: https://github.com/apache/spark/pull/27459#discussion_r376315052
##########
File path: sql/gen-sql-markdown.py
##########
@@ -47,6 +53,18 @@ def _list_function_infos(jvm):
return sorted(infos, key=lambda i: i.name)
+def _list_sql_configs(jvm):
+ sql_configs = [
+ SQLConfEntry(
+ name=_sql_config._1(),
+ default=_sql_config._2(),
Review comment:
> So would you want me to adjust the various defaults to use
`.createWithDefaultString()` as part of this PR? And if so, should I also fix
minor formatting issues in the docstrings as I come across them (e.g.
converting `'spark.config.name'` to `` `spark.config.name` ``)?
Are there a lot of instances of `'spark.config.name'` to ``
`spark.config.name` ``? If there are too many, let's do it in a separate PR.
For `.createWithDefaultString()`, yes, there seems only 5 ~ 6 instances
(except `.internal()` configurations). Looks fairly easy to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
