Eric5553 commented on a change in pull request #27368: [SPARK-30651][SQL] Add
detailed information for Aggregate operators in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/27368#discussion_r376698771
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectHashAggregateExec.scala
##########
@@ -67,7 +67,7 @@ case class ObjectHashAggregateExec(
initialInputBufferOffset: Int,
resultExpressions: Seq[NamedExpression],
Review comment:
I tried to rename one of the field `groupingExpressions` in sub-class
`HashAggregationExec`, found the compiler and IDE will show error notification
like:
```
class HashAggregationExec needs to be abstract, since value
groupingExpressions in class BaseAggregateExec of type
Seq[org.apache.spark.sql.catalyst.expressions.NamedExpression] is not defined
```
So maybe it's OK to keep it the concise style as I see in other places, e.g.
`HashJoin` & `ShuffledHashJoinExec`?
What do you think @gatorsmile @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
