beliefer commented on a change in pull request #27481: [SPARK-30758][SQL][TESTS] Improve bracketed comments tests. URL: https://github.com/apache/spark/pull/27481#discussion_r376747514
########## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql ########## @@ -26,23 +26,23 @@ SELECT 'after multi-line' AS fifth; SELECT 'trailing' as x1; -- inside block comment */ -/* This block comment surrounds a query which itself has a block comment... -SELECT /* embedded single line */ 'embedded' AS x2; -*/ +-- /* This block comment surrounds a query which itself has a block comment... +-- SELECT /* embedded single line */ 'embedded' AS x2; +-- */ Review comment: OK. I will not comment out nested comments and throw exception into golden files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
