hvanhovell commented on a change in pull request #27440: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function URL: https://github.com/apache/spark/pull/27440#discussion_r376787181
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ########## @@ -157,6 +157,38 @@ final class OffsetWindowFunctionFrame( override def currentUpperBound(): Int = throw new UnsupportedOperationException() } +class FixedOffsetWindowFunctionFrame( Review comment: Add documentation. I would like to see a unit test for this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
