Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/511#issuecomment-41229199
Very cool. This should be a pretty big performance win. Only minor
comments.
Regarding the question about normalizing expressions, it could be done in a
rule. However, really I think we can probably greatly simplify all of that
logic with code gen (hopefully coming in 1.1). So, given that you have already
written out all of the cases I don't think we need to do further simplification
in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
