ajithme commented on a change in pull request #27516:
[SPARK-30556][SQL][FOLLOWUP] Reset the status changed in
SQLExecution.withThreadLocalCaptured
URL: https://github.com/apache/spark/pull/27516#discussion_r376880573
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
##########
@@ -177,9 +177,17 @@ object SQLExecution {
val sc = sparkSession.sparkContext
val localProps = Utils.cloneProperties(sc.getLocalProperties)
Future {
+ val originalContext = SparkSession.getActiveSession
+ val originalLocalProps = Utils.cloneProperties(sc.getLocalProperties)
Review comment:
I think clone is required. Please read
https://github.com/apache/spark/pull/27267#discussion_r369023941
Also i dont see why we need to reset. By default pool threads do not have
any localproperties or localsession variable set. That means after the thread
is used for **first** time, this change will always try to retain those
properties and session by always finally resetting it to same, which is kind of
stale already. Right.?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
