MaxGekk commented on a change in pull request #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376985660
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -337,6 +337,7 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
case _ =>
}
+ localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)
Review comment:
HiveResult is used in `hive-thriftserver` too. If I set
`spark.sql.datetime.java8API.enabled` to `true` in
`HiveResult.hiveResultString`, this might effect on the Thrift server. Though I
can correct expected results in the tests, but Thrift server may require
broader changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
