MaxGekk commented on a change in pull request #27498: [SPARK-30688][SQL] Week
based dates not being parsed with TimestampFormatter
URL: https://github.com/apache/spark/pull/27498#discussion_r376722263
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -68,6 +68,17 @@ private object DateTimeFormatterHelper {
new DateTimeFormatterBuilder().parseCaseInsensitive()
}
+ def toWeekBasedFormatter(builder: DateTimeFormatterBuilder, locale: Locale):
DateTimeFormatter = {
+ builder
Review comment:
Most of the settings are similar to the builder settings in `toFormatter`.
Could you extract them to a separate method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
