Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2765#discussion_r25226058
  
    --- Diff: 
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
    @@ -1739,7 +1739,11 @@ public Integer call(String s) throws Exception {
       // Java arguments and assign it to a JavaDStream without producing type 
errors. Testing of the
       // InputStream functionality is deferred to the existing Scala tests.
       @Test
    -  public void testSocketTextStream() {
    +  public void testSocketTextStream(
    +
    +
    --- End diff --
    
    Yes, this is a good functionality to revive. Thanks Sean
    
    On Fri, Feb 20, 2015 at 4:17 AM, Sean Owen <notificati...@github.com> wrote:
    
    > In streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java
    > <https://github.com/apache/spark/pull/2765#discussion_r25066204>:
    >
    > > @@ -1739,7 +1739,11 @@ public Integer call(String s) throws Exception {
    > >    // Java arguments and assign it to a JavaDStream without producing 
type errors. Testing of the
    > >    // InputStream functionality is deferred to the existing Scala tests.
    > >    @Test
    > > -  public void testSocketTextStream() {
    > > +  public void testSocketTextStream(
    > > +
    > > +
    >
    > Undo this change?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/2765/files#r25066204>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to